Skip to content

Reuse JavaScript VM and other nits#428

Merged
sanderpick merged 1 commit intomasterfrom
sander/more-nits
Aug 27, 2020
Merged

Reuse JavaScript VM and other nits#428
sanderpick merged 1 commit intomasterfrom
sander/more-nits

Conversation

@sanderpick
Copy link
Copy Markdown
Contributor

Closes #423

  • Removes some cumbersome client types
  • Each collection stores its own JS VM and compiled JS functions for resuse
  • Properly returns the writeValidator and readFilter with other collection info in the gRPC API

Signed-off-by: Sander Pick <sanderpick@gmail.com>
@sanderpick sanderpick self-assigned this Aug 27, 2020
@sanderpick sanderpick requested a review from jsign August 27, 2020 20:28
Copy link
Copy Markdown
Contributor

@jsign jsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +132 to +141
// GetWriteValidator returns the current collection write validator.
func (c *Collection) GetWriteValidator() []byte {
return c.rawWriteValidator
}

// GetReadFilter returns the current collection read filter.
func (c *Collection) GetReadFilter() []byte {
return c.rawReadFilter
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@sanderpick sanderpick merged commit b544ccc into master Aug 27, 2020
@sanderpick sanderpick deleted the sander/more-nits branch August 27, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cache goja runtime and callables on Collection

2 participants