Error reporting: print newline characters escaped#99
Closed
stanislaw wants to merge 1 commit intotextX:masterfrom
Closed
Error reporting: print newline characters escaped#99stanislaw wants to merge 1 commit intotextX:masterfrom
stanislaw wants to merge 1 commit intotextX:masterfrom
Conversation
Potentially closes: textX/textX#397
Member
|
Thanks @mettta and @stanislaw for the contribution. The fix using See this branch. I will merge this to master shortly. |
Member
|
Resolved conflicts and merged to master. |
Contributor
Author
|
Hi @igordejanovic, is there a chance for this small but very useful change to be released already? Thanks. |
Member
|
Hi @stanislaw . Sure. I'll do the release in the following days. |
Member
|
@stanislaw I've just released 2.0.1 with this fix only. |
Contributor
Author
|
Thank you. I will check how it works with my project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is a contribution from @mettta and @stanislaw that addresses the issue textX/textX#397.
We are not sure if patching
StrMatch's_exp_strmethod is the right way to do it, so using this patch to open a discussion.When the implementation path is confirmed, we are happy to address the remaining contributor checklist's action points.
Code review checklist
CHANGELOG.md, no needto update for typo fixes and such).