Skip to content

Add PL translation #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkh-user merged 2 commits into from
Aug 9, 2025
Merged

Add PL translation #84

mkh-user merged 2 commits into from
Aug 9, 2025

Conversation

@Wiechciu
Copy link
Contributor

@Wiechciu Wiechciu commented Aug 8, 2025 •
edited
Loading

Pull Request Template

Title

Add PL translation

Type of Change

  • New feature
  • Refactoring

Description

Added PL translation and fixed minor typos in the other translations.

Testing

Tested that the text is properly displayed in PL and EN languages.

Impact

n/a

Additional Information

There are a lot of missing translation keys, which could be easily added and translated too. I only translated currently available keys.
Selecting the language could be improved as well to be able to select only available translations, not a free text code.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings

@mkh-user
Copy link
Member

mkh-user commented Aug 9, 2025

Merged!

About new keys, yes, I will working on a translation branch for new keys.
About select language I currently working on it, maybe separated UI for language change or create a new option list type for settings.

@mkh-user mkh-user merged commit b18fada into text-forge:Main Aug 9, 2025
1 check passed
@Wiechciu
Copy link
Contributor Author

Wiechciu commented Aug 9, 2025

@mkh-user did you consider doing proper gettext translation instead of using csv? For some languages (like Polish) the csv is not enough to properly translate some text, especially when it includes numbers. I could help you set it up if you haven't done it yet

@mkh-user
Copy link
Member

mkh-user commented Aug 9, 2025

Thanks a lot for the suggestion! I've been using CSV so far mainly because it was a simpler starting point, but I totally agree that for languages like Polish (and even Persian), gettext would handle plural forms and context much better.

If you're up for it, feel free to open an issue to track this or even submit a PR to get it started — I'd really appreciate your help!
If you decide to work on it, I’ll be happy to help along the way. And if not, I’ll try to look into it myself when I get a chance.

@Wiechciu
Copy link
Contributor Author

Wiechciu commented Aug 9, 2025

Alright, will do. Cheers!

@Wiechciu Wiechciu mentioned this pull request Aug 12, 2025
Closed
@Wiechciu Wiechciu deleted the pl-translation branch August 12, 2025 18:16
@Wiechciu Wiechciu added the i18n label Aug 20, 2025
@mkh-user mkh-user added this to the Text Forge 0.1 milestone Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Wiechciu Wiechciu

Labels

None yet

Projects

Release: Text Forge 1.0
Status: Completed

Milestone

Text Forge 0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@Wiechciu @mkh-user