Skip to content

Add auto text writing direction to editor #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkh-user merged 1 commit into from
Dec 3, 2025
Merged

Add auto text writing direction to editor #144

mkh-user merged 1 commit into from
Dec 3, 2025

Conversation

@mkh-user
Copy link
Member

@mkh-user mkh-user commented Dec 3, 2025 •
edited by coderabbitai bot
Loading

Summary of Changes

Changes editors Text Writing Direction from Left-to-Right to Auto.

Checklist

  • Linked all relevant issues/PRs/discussions
  • Code follows project style and guidelines
  • Self-reviewed and tested thoroughly
  • Documentation updated (if applicable)
  • No new warnings or errors introduced
  • Relevant changes added to CHANGELOG

Summary by CodeRabbit

  • New Features
    • Automatic text writing direction support has been implemented in the editor. The editor now intelligently detects and applies the correct text orientation for various language scripts and writing systems. This enhancement improves the overall editing and display experience for multilingual content, while eliminating the need for manual direction adjustments or configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

Added auto text writing direction support for the editor. Updated the CHANGELOG to document this feature and added a text_direction property to the Editor CodeEdit node in the scene configuration to enable the functionality.

Changes

Cohort / File(s) Summary
Documentation
CHANGELOG.md		 Added entry documenting auto text writing direction feature for editor
Editor Configuration
core/main.tscn		 Added text_direction = 0 property to the Editor CodeEdit node

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main change: adding auto text writing direction to the editor, which aligns with the file modifications and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch auto-text-writing-direction
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca7401c and d83fb89.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • core/main.tscn (1 hunks)
🔇 Additional comments (2)
CHANGELOG.md (1)

25-25: LGTM! Changelog entry is clear and well-formatted.

The changelog entry properly documents the feature addition with correct linking to the PR.

core/main.tscn (1)

189-189: text_direction = 0 is correct and corresponds to DIRECTION_AUTO in Godot 4.5.

This enables automatic text direction detection based on content, which is appropriate for the Editor CodeEdit node configuration.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mkh-user mkh-user added the triage Awaiting initial review, classification, or prioritization by maintainers label Dec 3, 2025
@mkh-user mkh-user self-assigned this Dec 3, 2025
@mkh-user mkh-user removed the triage Awaiting initial review, classification, or prioritization by maintainers label Dec 3, 2025
@mkh-user mkh-user moved this from Needs Review to In Progress in Release: Text Forge 1.0 Dec 3, 2025
@mkh-user mkh-user added this to the Text Forge 0.2 milestone Dec 3, 2025
@mkh-user mkh-user merged commit d302273 into Main Dec 3, 2025
2 checks passed
@mkh-user mkh-user deleted the auto-text-writing-direction branch December 3, 2025 07:33
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Release: Text Forge 1.0 Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mkh-user mkh-user

Labels

None yet

Projects

Release: Text Forge 1.0
Status: Completed

Milestone

Text Forge 0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@mkh-user