action_scripts/scenes/template_manager.gd (2)

44-47: Guard against selecting guidance items.

When the template list is empty, lines 15-16 add non-selectable guidance messages. If a user somehow selects one of these items (e.g., through keyboard navigation or a race condition), lines 46-47 would attempt to load a non-existent template file, causing an error.

Apply this diff:

 func _on_templates_item_selected(index: int) -> void:
+	# Skip if this is a guidance message
+	if not templates.is_item_selectable(index):
+		return
 	preview_panel.show()
 	template_name.text = templates.get_item_text(index)
 	preview.text = FileAccess.get_file_as_string(S.TEMPLATE_TEMPLATES.format([template_name.text]))

---

38-41: Handle trash failures and refactor list refresh.

Line 39 doesn't check if OS.move_to_trash() succeeds, which could fail silently. Line 41 calls _ready() to refresh the list, but _ready() is a lifecycle method and shouldn't be manually invoked.

Apply this diff:

 func _delete_template() -> void:
-	OS.move_to_trash(S.globalize_path(S.TEMPLATE_TEMPLATES.format([template_name.text])))
+	var path := S.globalize_path(S.TEMPLATE_TEMPLATES.format([template_name.text]))
+	var err := OS.move_to_trash(path)
+	if err != OK:
+		Global.send_notification(Global.Notification.ERROR, "Failed to remove template!", "Error code: " + str(err))
+		return
 	preview_panel.hide()
-	_ready()
+	_reload_list()
+
+func _reload_list() -> void:
+	templates.clear()
+	if not DirAccess.dir_exists_absolute(S.globalize_path(S.FOLDER_TEMPLATES)):
+		DirAccess.make_dir_recursive_absolute(S.globalize_path(S.FOLDER_TEMPLATES))
+	for t in DirAccess.get_files_at(S.FOLDER_TEMPLATES):
+		templates.add_item(t.get_basename())
+	if templates.item_count == 0:
+		templates.add_item("There is no template to show!", null, false)
+		templates.add_item("Use Format > Save As Template to create one.", null, false)

action_scripts/save_as_template.gd (1)

15-33: Remove unrelated file name mutation and add overwrite warning.

Line 32 removes the unsaved indicator (*) from the current file's name when saving a template. This is incorrect because saving as a template doesn't save the current file—it only creates a new template file. Additionally, there's no warning when overwriting an existing template.

Apply this diff:

 func _save_template(_name: String) -> void:
 	_name = _name.strip_edges().validate_filename()
 	if _name.is_empty():
 		Global.send_notification(Global.Notification.ERROR, "Invalid template name!", "Please use letters, numbers, space, dash or underscore.")
 		return
 	if not DirAccess.dir_exists_absolute(S.globalize_path(S.FOLDER_TEMPLATES)):
 		DirAccess.make_dir_recursive_absolute(S.globalize_path(S.FOLDER_TEMPLATES))
 	var path := S.TEMPLATE_TEMPLATES.format([_name])
+	if FileAccess.file_exists(path):
+		Global.send_notification(Global.Notification.WARNING, "Template exists", "Overwriting existing template: " + _name)
 	var file_access := FileAccess.open(path, FileAccess.WRITE)
 	var err := FileAccess.get_open_error()
 	if err or not file_access:
 		Global.send_notification(Global.Notification.ERROR, "Failed to save file as template!", "Error code: " + str(err))
 		return
 	file_access.store_string(Global.get_editor_text())
 	file_access.close()
 	Global.send_notification(Global.Notification.INFO, "File saved as template!")
 	Global.get_core().reload_templates()
-	Global.set_file_name(Global.get_file_name().replace("*", ""))
 	Signals.open_file.emit(path)

core/main.gd (1)

48-51: Inconsistent comment formatting for method references.

Line 48 references _reload_recent_files while line 50 references _reload_templates, but the actual method on line 416 is reload_templates (without underscore prefix). The comments should consistently reference the actual method names.

Apply this diff:

-## Recent files [PopupMenu], see also [method _reload_recent_files].
+## Recent files [PopupMenu], see also [method _reload_recent_files()].
 var recent_files_submenu: PopupMenu
-## Templates [PopupMenu], see also [method _reload_templates].
+## Templates [PopupMenu], see also [method reload_templates()].
 var templates_submenu: PopupMenu

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro