Priority based action script loading #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8c7a7ee.
Contributor
WalkthroughIntroduces two-phase loading of action scripts in core/main.gd with a new _main_scripts_loaded callback and emits a check_options signal between phases. Updates performance testing to use multiple flags and parameterized behavior. Adjusts CodeEdit UI properties in the scene. Adds documentation updates and expands performance metrics and flow in tests/performance.gd. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Main as Main (core/main.gd)
participant Loader as ScriptLoader
participant Signals
participant Editor
User->>Main: Start app
Main->>Loader: load(main-script paths)
Loader-->>Main: main scripts loaded
Main->>Main: _main_scripts_loaded()
Main->>Signals: emit check_options
Main->>Loader: load(low-priority scripts)
Loader-->>Main: all scripts loaded
Main->>Main: _all_scripts_loaded()
alt last file auto-opened
Main->>Editor: grab_focus()
end
sequenceDiagram
autonumber
participant Tests as Autoload Tests
participant Perf as tests/performance.gd
participant Panels as PanelManager
participant Signals
Tests->>Perf: new(startup, open_file)
alt startup == true
Perf->>Perf: record start_time on first frame
Perf->>Panels: await load_completed
Panels-->>Perf: completed
Perf->>Signals: await check_options
Signals-->>Perf: received
Perf->>Perf: print main scripts time, total startup, all scripts time, total setup
end
alt open_file == true
Tests-->>Perf: open_started signal
Perf->>Perf: measure open-file time
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Action Scripts are divided into two main categories (file menu) and secondary (the rest). The user interface will be fully usable after loading the main items, so there is no need to wait until the end of the loading process. This roughly halves the actual startup time (-60.4%), although the overall startup is slightly slower.
Testing
Works perfectly.
Impact
Environment
Before
After
Overall Comparison
Additional Information
This update includes test improvements, improvements in the behavior of automatically loading the last file, a separate loader for main Action Scripts, setting the default values of the View menu as the editor default, and removing the search_delay parameter from the performance test.
Checklist
Summary by CodeRabbit
New Features
Documentation
Tests