Add support for multiple save requests #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
When a module emits
save_request, if there is any dialog currently, an error generates; this change fixes it. Now, when you emitsave_requestand there is any dialog, SignalBus will wait until dialog removing and emitssave_finishedwith givencallback, so all requests will be handled.Testing
Works fine and removes error.
Impact
Adds a small delay before duplicate
save_finishedbased on garbage collection speed. This makes closing a little bit slower so it isn't very bad.Additional Information
Nothing
Checklist