Skip to content

Conversation

@mkh-user
Copy link
Member

@mkh-user mkh-user commented Sep 15, 2025

Type of Change

  • Bug fix

Description

When a module emits save_request, if there is any dialog currently, an error generates; this change fixes it. Now, when you emit save_request and there is any dialog, SignalBus will wait until dialog removing and emits save_finished with given callback, so all requests will be handled.

Testing

Works fine and removes error.

Impact

Adds a small delay before duplicate save_finished based on garbage collection speed. This makes closing a little bit slower so it isn't very bad.

Additional Information

Nothing

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings
  • Changes were added to CHANGELOG

@coderabbitai

This comment was marked as outdated.

@mkh-user mkh-user self-assigned this Sep 15, 2025
@mkh-user mkh-user added action scripts Official action scripts or action scripts features scope: code labels Sep 15, 2025
@mkh-user mkh-user added this to the Text Forge 0.2 milestone Sep 15, 2025
@mkh-user mkh-user added the bug A confirmed issue causing incorrect behavior or unexpected results label Sep 15, 2025
@mkh-user mkh-user moved this to In Progress in Release: Text Forge 1.0 Sep 15, 2025
@mkh-user mkh-user force-pushed the multiple-save-request-handling branch from d4d9506 to 3346589 Compare September 16, 2025 13:57
@mkh-user mkh-user merged commit 51c43e0 into Main Sep 16, 2025
2 checks passed
@mkh-user mkh-user deleted the multiple-save-request-handling branch September 16, 2025 13:57
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Release: Text Forge 1.0 Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action scripts Official action scripts or action scripts features bug A confirmed issue causing incorrect behavior or unexpected results

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

2 participants