user macros can be "activated" (checked)#4361
Merged
sunderme merged 7 commits intotexstudio-org:masterfrom Mar 13, 2026
Merged
Conversation
Member
|
1)The issue is about deactivating triggers (and maybe shortcuts).
|
sunderme
reviewed
Mar 11, 2026
src/macrobrowserui.cpp
Outdated
Comment on lines
+37
to
+39
| checkBox=new QCheckBox(); | ||
| checkBox->setChecked(false); | ||
| auto *lblCheckBox=new QLabel(tr("Import as active macros")); |
Member
There was a problem hiding this comment.
default is active, this has to go
sunderme
reviewed
Mar 11, 2026
src/texstudio.cpp
Outdated
| // add elements | ||
| for(const auto &m:configManager.completerConfig->userMacros) { | ||
| if (m.name == TXS_AUTO_REPLACE_QUOTE_OPEN || m.name == TXS_AUTO_REPLACE_QUOTE_CLOSE || m.document) | ||
| if (m.name == TXS_AUTO_REPLACE_QUOTE_OPEN || m.name == TXS_AUTO_REPLACE_QUOTE_CLOSE || m.document || m.checkState() != Qt::Checked) |
sunderme
reviewed
Mar 11, 2026
src/texstudio.cpp
Outdated
|
|
||
| void Texstudio::execMacro(const Macro &m, const MacroExecContext &context, bool allowWrite) | ||
| { | ||
| if (m.checkState() != Qt::Checked) return; |
Member
There was a problem hiding this comment.
only trigger and maybe shortcut are to be deactivated
sunderme
reviewed
Mar 11, 2026
sunderme
reviewed
Mar 11, 2026
sunderme
reviewed
Mar 11, 2026
src/macrobrowserui.cpp
Outdated
Comment on lines
+45
to
+48
| hlayout->addWidget(checkBox); | ||
| hlayout->addWidget(lblCheckBox); | ||
| hlayout->addWidget(buttonBox); | ||
| layout->addLayout(hlayout); |
c93e53e to
db19238
Compare
sunderme
reviewed
Mar 12, 2026
src/usermenudialog.cpp
Outdated
| { | ||
| QTreeWidgetItem *item = ui.treeWidget->currentItem(); | ||
| if (item==nullptr) return; | ||
| if (item==nullptr || item->checkState(0)!=Qt::Checked) return; |
Member
There was a problem hiding this comment.
why is the "execute macro" button blocked with active/inactive macro ?
sunderme
reviewed
Mar 12, 2026
src/usermenudialog.cpp
Outdated
| } | ||
| } | ||
|
|
||
| void UserMenuDialog::checkStateChanged(QTreeWidgetItem *item) |
Member
There was a problem hiding this comment.
not sure why the checkstate is not just queried at getMacros ?
- don't test unchecked macros for duplicate trigger with quotes macros - update shortcuts for checked macros only - counter used needs to be the same as in original (full) user macros list
5508ff5 to
d5478e1
Compare
Member
|
and at last, there should be a tooltip on the checkboxes, so that user may know what they are deactivating |
Contributor
Author
|
ok, I was thinking about tooltips at the beginning. But I assumed this could be to much UI activity while cursor is moving. Do you have an idea regarding the latexcompleter (s. question above)? |
Contributor
Author
|
tooltips also for folder items? |
set checkState in getMacros and on exportMacros toolTips
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final remarks about results from the comments:
Macros are not really deactivated when they are not checked. They are still visible in the Macro menu as well as in the side panel and can be executed from there. You can also execute them in the Macro Editor by pressing the Exec button. While the macro shortcut and trigger won't work (s. added tooltip), the abbreviation can still be used. No checkbox has been added to the macro browser (repo). Any macro downloaded from there will be "activated" (checked).
Original PR
This PR resolves #3971. I made commits (starting with class changes) for each file changed. Some commits give further details. So I hope it's easier to understand. I also added some testing.
Loading/importing macros set checked macros not having checkState element, otherwise they are checked accordingly.
When importing from macro repo you can decide what checkState they should have (s. image below).
Screenshots:
show only checked macros in side bar and menu:
Tree view in macro editor:
Macro browser (macro repo):