fix pages/grid after switching single page step#3957
Merged
sunderme merged 2 commits intotexstudio-org:masterfrom Jan 20, 2025
Merged
fix pages/grid after switching single page step#3957sunderme merged 2 commits intotexstudio-org:masterfrom
sunderme merged 2 commits intotexstudio-org:masterfrom
Conversation
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes following two cases (alway start with non singlePageOffset). Left half of the images from master, right half fixed (s. details in txs window title).
Set non continuous, pageOffset>0. Scroll to top. Now setting singlePageStep moves pages and leaves empty grid faces at lower right of the grid:
click to enlarge
click to enlarge
This issue is a direct consequence of fixing calculation of visible pages/pages list fix pdf-viewer's page display in non continuous mode #3952. This is fixed with
reloadPage.Set continuous, pageOffset>0 and last grid row has at most pageOffset many pages (f.ex. gridx=3 and 11 pages). Scroll to end. Then setting singlePageStep moves last pages to previous line and last grid row is empty. Have a close look at the different scrollbars to the left and right. To the left you can sroll down to the empty row. But overscroll should't be possible with continuous. Also, returning back works with fixed version: Switching to non singlePageStep brings back the row on the right side:
click to enlarge
click to enlarge
This is fixd with
updateScrollBars. I see no difference when removingdelayedUpdate.