make menu entries Show embedded PDF large/small consistent#3931
make menu entries Show embedded PDF large/small consistent#3931sunderme merged 3 commits intotexstudio-org:masterfrom
Conversation
src/texstudio.cpp
Outdated
| newManagedAction(menu, "enlargePDF", tr("Show embedded PDF large"), SLOT(enlargeEmbeddedPDFViewer())); | ||
| newManagedAction(menu, "shrinkPDF", tr("Show embedded PDF small"), SLOT(shrinkEmbeddedPDFViewer())); | ||
|
|
||
| newManagedAction(menu, "enlargePDF", tr("Show embedded PDF large"), SLOT(enlargeEmbeddedPDFViewer()))->setVisible(false); |
There was a problem hiding this comment.
please make two lines out of this, i.e
act=...
act->setVi...
There was a problem hiding this comment.
and the approach seems to be a bit indirect.
You want to change menu entries in texstudio.cpp level, the changes are triggered there (even embedding/windowing over Texstudio::runInternalPdfViewer)
src/texstudio.cpp
Outdated
| newManagedAction(menu, "shrinkPDF", tr("Show embedded PDF small"), SLOT(shrinkEmbeddedPDFViewer())); | ||
|
|
||
| newManagedAction(menu, "enlargePDF", tr("Show embedded PDF large"), SLOT(enlargeEmbeddedPDFViewer()))->setVisible(false); | ||
| newManagedAction(menu, "shrinkPDF", tr("Show embedded PDF small"), SLOT(shrinkEmbeddedPDFViewer()))->setVisible(false); |
There was a problem hiding this comment.
please make two lines out of this, i.e
act=...
act->setVi...
There was a problem hiding this comment.
Just in case that there was no automatic notification, I want to note that I changed the two lines.
|
Did you see my other comment ? |
|
There are two pairs of similar actions, one of them connected to a button of PDFdocument. So it seems best to me to use the ui changes to setup the menu and the button. |
|
I have looked through the code. Please rewrite the code that the menu change is done in the TexStudio class only. Secondly, the menu should be disabled, not hidden. The menu entries are always a good learning source for shortcuts. |
|
Thanks for the hints. I made a new commit. |
|
and updatet first commit (images etc.) of th PR. |
|
thanks |
This PR adresses following two menu entries:
Both actions are always enabled even when there is no pdf-viewer at all or the viewer is not embedded. When the viewer is emedded exactly one of the entries should be enabled. So we have three cases: