TexDoc dialog: check all packages option without packages present#3917
Merged
sunderme merged 1 commit intotexstudio-org:masterfrom Dec 20, 2024
Merged
TexDoc dialog: check all packages option without packages present#3917sunderme merged 1 commit intotexstudio-org:masterfrom
sunderme merged 1 commit intotexstudio-org:masterfrom
Conversation
Member
|
if you open texsdoc once without a document, the "show all" will stick, even if it was not changed by the user. |
d0bec83 to
7a15b02
Compare
Contributor
Author
|
@sunderme Thanks, you may check again. |
sunderme
reviewed
Dec 20, 2024
src/help.cpp
Outdated
| } | ||
| mShowAllPackages=dialog.showAllPackages(); | ||
| if (packages.count()==0) { | ||
| mShowAllPackages = false; |
Member
There was a problem hiding this comment.
It should not force mShowAllPackages to false either. It just should not change the previous state which maybe true or false.
7a15b02 to
bf00c18
Compare
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings back following functionality (discussion #3478 (comment), lost by 277e8c8): When txs starts without any documents the Package help (TexDoc) dialog should automatically check option
all packages. Otherwise you have to do so manually before you can search anything. As a side effect this fixes that the packages list is emtpy although the documentation of a0poster is presented.