add alignedat env to QuickArray wizard#3066
Conversation
table text is aligned accordingly to alignment settings
|
this will be integrated for 4.5.3 when accepted. |
|
I have some comments:
|
|
ad 1) Squash option can be disabled in case you want to modify the alignment settings afterwards. Such modifications could be adding vertical lines or using paragraph cells. In such cases unsquashing might be unnecessary work. ad 2) I see the point, even so some remarks. One tricky thing of the package names is that those of mathtools (the stared ones) look similar to those from amsmath without star. Someone might conclude that this is the same as with envs not having a number. But in this case the star has a completely different meaning. So selecting the package doesn't mix things and keeps the list short. And marking the package for each entry is not my preferred solution. Maybe we can find something better. ad 3) In this QuickArray dialog most settings can be reproduced easily. Quick Tabular has much more settings but doesn't remember any of them. Overall I'm not convinced that it's likely that same settings are needed in sequence. If I'm wrong someone will create an enhancement request. What could be desirable is a way of setting the alignment for several columns of an array at once (by selecting cells in different columns). But one has to think about how the workflow for this could be (because only one alignment can be selected in the alignment combo box). ad 4) Why note something in the header that is obvious? QuickTabular is different (s. 1) and shows things (vertical lines) in the header which are not visible in the cells. An example for QuickArray shows this (right, center, left): |
|
- no more squash option (factoring alignments) - no more package selection - all envs in one combo box list (incl. 2 separators) and changed tooltip for env combo box - table header shows current column alignments
|
Qt5 (5.12) is still mandatory for txs. |
|
looks okay. |
|
I suggest not to inhibit changing alignment if it seems that this has no effect. Most important if you add columns then this value is used as default alignment for these columns when you later on choose env array (even if current env is not array). Also you can pre-select the alignment for matrix* and the like (even so this can be done easily after changing the env). Currently working on storing options. Main problem you may help me with is that I need to store the array of alignment indices (for array columns), i.e. a list of integers. Currently I use these lines (not following immediately each other): I use this because there is no other object like combo boxes of the dialog (so I assume that "this" is the dialog object). Error message: |
|
I don't think that |
|
texstudio.cpp calls a ArrayDialog:: method that does the registerOptions. This is the same as QuickStart does. And I can see that all other options of QuickArray are stored. |
|
or simpler QString with the "lllcl" etc. text. Markdown... |
?? |
|
You saw that I edited my previous comment ? |
|
So, I merge this request as is ? |
|
you may do so. I hope that I can add storing settings in the next five weeks. |




This PR resolves #2921. Key information:
(1) since all currently supported envs need math mode I added alignedat, not alignat or alignat*.