use position of selection instead of context menu#2807
Merged
sunderme merged 2 commits intotexstudio-org:masterfrom Dec 29, 2022
octaeder:clearPreview
Merged
use position of selection instead of context menu#2807sunderme merged 2 commits intotexstudio-org:masterfrom octaeder:clearPreview
sunderme merged 2 commits intotexstudio-org:masterfrom
octaeder:clearPreview
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adopts the behavior of starting preview via context menu when deleting the preview. Now in both cases if there is a selection then the position of the selection is used, not that of the context menu. Thus you can make a selection, preview it (even if the context menu is opened with the cursor over a begin{xyz} not contained in the selection) and then remove the preview without having to move the pointer over the selected text (or the preview image). This had already been implemented in PR #2803 which had been changed.
This finally closes #2794.