Skip to content

add menu LaTeX/Horizontal Spacing#2722

Merged
sunderme merged 5 commits intotexstudio-org:masterfrom
octaeder:horizontalSpacingMenu
Dec 4, 2022
Merged

add menu LaTeX/Horizontal Spacing#2722
sunderme merged 5 commits intotexstudio-org:masterfrom
octaeder:horizontalSpacingMenu

Conversation

@octaeder
Copy link
Copy Markdown
Contributor

@octaeder octaeder commented Dec 4, 2022 •
edited
Loading

This PR closes #2687.

Additionally:

  • added \vfill to menu Vertical Spacing

Question: Where are the info texts displayed or are they only documentation? Hoped they would be tooltips.

@octaeder
add menu LaTeX/Horizontal Spacing
c6639ba 
Additionally:
- added \baselineskip and \vfill to menu Vertical Spacing
- correcting displaying commands without slashes
- correcting menu item with submenu (no pending dots)
@mbertucci47
Copy link
Copy Markdown
Contributor

mbertucci47 commented Dec 4, 2022

I would not include \baselineskip since it is a length/skip, not a document command like the rest in that list. Unrelated, the words "positive" and "negative" in the \vspace entry are missing the "e", and "vertically" in the \vfill entry has an extra "t".

sunderme
sunderme reviewed Dec 4, 2022
View reviewed changes
sunderme
sunderme reviewed Dec 4, 2022
View reviewed changes
sunderme
sunderme reviewed Dec 4, 2022
View reviewed changes
@sunderme
Copy link
Copy Markdown
Member

sunderme commented Dec 4, 2022

I would strongly recommend not to mix different changes in one PR.
One PR for adding a part of the menu which probably would be accepted quite easily and other PRs for renaming stuff (which are not accepted as stated above)
I can not cherry-pick ...

@octaeder octaeder marked this pull request as draft December 4, 2022 11:33
@octaeder octaeder marked this pull request as ready for review December 4, 2022 12:04
@octaeder
Copy link
Copy Markdown
Contributor Author

octaeder commented Dec 4, 2022

understood
reason was that the menus are a mix of commands with slashes and without slashes
menu item with three dots means that a dialog will pop up, so selecting the item can still be canceled (windows style guide?)
thx for reviewing to @mbertucci47 and @sunderme

sunderme
sunderme reviewed Dec 4, 2022
View reviewed changes
@sunderme sunderme merged commit adabd78 into texstudio-org:master Dec 4, 2022
@sunderme
Copy link
Copy Markdown
Member

sunderme commented Dec 4, 2022

thanks

@octaeder octaeder deleted the horizontalSpacingMenu branch December 4, 2022 16:59
@octaeder octaeder mentioned this pull request Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunderme sunderme sunderme left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Horizontal Spacing commands in the menu for common commands

3 participants

@octaeder @mbertucci47 @sunderme