fixes race condition in Run by decoupling singal handling from the impl#458
Merged
fixes race condition in Run by decoupling singal handling from the impl#458
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
codefromthecrypt
approved these changes
Mar 19, 2025
Contributor
codefromthecrypt
left a comment
There was a problem hiding this comment.
right, this wasn't originally designed to be called as a library, so moving the signal handling to main makes sense.
Contributor
Author
|
The tests running both on EG (envoyproxy/gateway#5527) and AIGW (envoyproxy/ai-gateway#458) using this branch. good to go |
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of #456. Basically, the original impl had a race condition and cannot wait for the Envoy processes to actually exit plus there was a race condition when accessing exec.Process objects. This fixes it altogether by decoupling internal/envoy/run implementation from the actual signal handling and making it focus on the simple context cancelation.