Skip to content

fix: Bump @testing-library/dom to v7.26.0#799

Merged
kentcdodds merged 1 commit intotesting-library:masterfrom
theashraf:fix/bump-testing-library-dom-version
Oct 14, 2020
Merged

fix: Bump @testing-library/dom to v7.26.0#799
kentcdodds merged 1 commit intotesting-library:masterfrom
theashraf:fix/bump-testing-library-dom-version

Conversation

@theashraf
Copy link
Copy Markdown
Contributor

@theashraf theashraf commented Oct 14, 2020 •
edited
Loading

What:
Bump @testing-library/dom to v7.26.0

Why:
to use the logPlaygroundUrl method added to the screen

How:

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Oct 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ff1349c:

Sandbox Source
React Configuration
kentcdodds/react-testing-library-examples Configuration

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #799 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #799   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          117       117           
  Branches        16        16           
=========================================
  Hits           117       117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c546a6f...ff1349c. Read the comment docs.

kentcdodds
kentcdodds approved these changes Oct 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to get the latest version of @testing-library/dom by doing a fresh install because our version range should pull it in automatically. But sure :)

@kentcdodds kentcdodds merged commit 6b9a720 into testing-library:master Oct 14, 2020
@kentcdodds
Copy link
Copy Markdown
Member

kentcdodds commented Oct 14, 2020

@all-contributors please add @theashraf for code

@allcontributors allcontributors bot mentioned this pull request Oct 14, 2020
Merged
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors bot commented Oct 14, 2020

@kentcdodds

I've put up a pull request to add @theashraf! 🎉

@testing-library-bot
Copy link
Copy Markdown

testing-library-bot commented Oct 14, 2020

🎉 This PR is included in version 11.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theashraf @kentcdodds @testing-library-bot