fix: Trigger ongot-/onlostpointercapture when calling got-/lostpointercapture#786
Merged
eps1lon merged 5 commits intotesting-library:masterfrom Sep 13, 2020
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
1 task
Codecov Report
@@ Coverage Diff @@
## master #786 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 117 117
Branches 16 16
=========================================
Hits 117 117 Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 11.0.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Calling
fireEvent.gotPointerCaptureorfireEvent.lostPointerCaptureshould trigger their corresponding React event listeners.Why:
Reveals issues with
gotpointercaptureandlostpointeraptureHow:
@testing-library/domto version including fix(events): got-/lostpointercapture bubble dom-testing-library#767Checklist:
[ ] Documentation added to thedocs site
[ ] Typescript definitions updated