Skip to content

doc: update the cheat sheet pdf + source file to fix typo#782

Merged
kentcdodds merged 1 commit intotesting-library:masterfrom
tapico-weyert:fix-cheatsheet-pdf
Sep 8, 2020
Merged

doc: update the cheat sheet pdf + source file to fix typo#782
kentcdodds merged 1 commit intotesting-library:masterfrom
tapico-weyert:fix-cheatsheet-pdf

Conversation

@tapico-weyert
Copy link
Copy Markdown
Contributor

@tapico-weyert tapico-weyert commented Sep 8, 2020

What:
Fixes a typo in the Javascript in the Cheat sheet pdf

Why:
🐶

How:
I have updated the Affinity Publisher document and exported a PDF

Checklist:
N/A

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Sep 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 8, 2020 •
edited
Loading

Codecov Report

Merging #782 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #782   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          109       109           
  Branches        16        16           
=========================================
  Hits           109       109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32fea0...5434cfc. Read the comment docs.

@kentcdodds
Copy link
Copy Markdown
Member

kentcdodds commented Sep 8, 2020

Thanks! It looks like the afpub doc was deleted 🤔

@weyert
Copy link
Copy Markdown
Contributor

weyert commented Sep 8, 2020

Hmm, that wasn't the intention and the appears to be still in my repo directory. Did get a lot smaller by the looks of it

kentcdodds
kentcdodds approved these changes Sep 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense. Thanks!

@kentcdodds kentcdodds merged commit 865c4fd into testing-library:master Sep 8, 2020
@tapico-weyert tapico-weyert deleted the fix-cheatsheet-pdf branch September 9, 2020 01:09
@testing-library-bot
Copy link
Copy Markdown

testing-library-bot commented Sep 13, 2020

🎉 This PR is included in version 11.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tapico-weyert @kentcdodds @weyert @testing-library-bot