fix: Update typings for cleanup#776
Merged
eps1lon merged 1 commit intotesting-library:masterfrom Sep 3, 2020
artem-malko:pr/update-cleanup-types
Merged
fix: Update typings for cleanup#776eps1lon merged 1 commit intotesting-library:masterfrom artem-malko:pr/update-cleanup-types
eps1lon merged 1 commit intotesting-library:masterfrom
artem-malko:pr/update-cleanup-types
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6661561:
|
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 109 109
Branches 16 16
=========================================
Hits 109 109 Continue to review full report at Codecov.
|
Member
|
@all-contributors add @artem-malko for code |
Contributor
|
I've put up a pull request to add @artem-malko! 🎉 |
|
🎉 This PR is included in version 11.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Update types for cleanup function.
cleanupbecame sync, but in typings it returns Promise.Update was there: #768
Why:
Cause now types are not valid for real code.
How:
Just manually update typings)
Checklist:
docs site
It might be cool to update typings automatically. I can create an issue, but do not have much time to implement it(