feat: add toBePressed matcher (#203)#658
Merged
gnapse merged 2 commits intotesting-library:mainfrom Aug 13, 2025
kretajak:feat/add-to-be-pressed-matcher
Merged
feat: add toBePressed matcher (#203)#658gnapse merged 2 commits intotesting-library:mainfrom kretajak:feat/add-to-be-pressed-matcher
gnapse merged 2 commits intotesting-library:mainfrom
kretajak:feat/add-to-be-pressed-matcher
Conversation
Contributor
Author
|
Hi, may I ask for reviews? |
Contributor
Author
|
Hi @gnapse, can I kindly ask for a review? |
gnapse
requested changes
Aug 11, 2025
Member
gnapse
left a comment
There was a problem hiding this comment.
Thanks for making this contribution. It is good stuff. Though there are a couple of things that need to be improved.
(the comments marked as "nit-pick" are not fundamental to be changed, but other ones are)
gnapse
approved these changes
Aug 13, 2025
Member
|
@all-contributors please add @kretajak for code, test |
Contributor
|
I've put up a pull request to add @kretajak! 🎉 |
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 tasks
Contributor
Author
|
I have created a follow-up with |
This was referenced Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
New
toBePressedmatcher is addedWhy:
Closes #203
Checklist:
In my opinion this PR could be followed by another one which would add support for checking
aria-pressed="mixed". MaybetoBePartiallyPressed? It would follow the same approach as splittertoBeCheckedandtoBePartiallyCheckedinto two separate matchers.