docs: add definitely typed requirement#496
Closed
thiagomini wants to merge 1 commit intotesting-library:mainfrom
Closed
docs: add definitely typed requirement#496thiagomini wants to merge 1 commit intotesting-library:mainfrom
thiagomini wants to merge 1 commit intotesting-library:mainfrom
Conversation
4 tasks
|
🎉 This issue has been resolved in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Adds a brief section explaining that the dev should also install the types via DT to be able to use this library with Typescript
Why:
It wasn't obvious to me (and I believe to others) that this library did not come with type definitions out of the box. I thought it was an issue with
tsconfig.json, but it was only due to missing the types package.How:
Added a few lines to the typescript section
Checklist: