Conversation
…back feat(no-wait-for-empty-callback ): new rule no-wait-for-empty-callback
* feat(prefer-wait-for): new rule prefer-wait-for * docs(prefer-wait-for): pr fixes * test(prefer-wait-for): increase coverage * refactor(prefer-wait-for): use ternary * docs(prefer-wait-for): PR small fixes Co-Authored-By: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com> * test(prefer-wait-for): include imports * fix(prefer-wait-for): fist attempt to report related imports * refactor(prefer-wait-for): merge wait reports under single func * fix(prefer-wait-for): fix single imports * fix(prefer-wait-for): fix several imports * fix(prefer-wait-for): guard against empty named imports * fix(prefer-wait-for): fix more imports cases Fix multiline imports and avoid duplicating waitFor import if already present * feat(prefer-wait-for): new rule prefer-wait-for * docs(prefer-wait-for): pr fixes * test(prefer-wait-for): increase coverage * refactor(prefer-wait-for): use ternary * docs(prefer-wait-for): PR small fixes Co-Authored-By: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com> * test(prefer-wait-for): include imports * fix(prefer-wait-for): fist attempt to report related imports * refactor(prefer-wait-for): merge wait reports under single func * fix(prefer-wait-for): fix single imports * fix(prefer-wait-for): fix several imports * fix(prefer-wait-for): guard against empty named imports * fix(prefer-wait-for): fix more imports cases Fix multiline imports and avoid duplicating waitFor import if already present Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
BREAKING CHANGE: Drop support for node v8. Min version allowed is node v10.12
Belco90
commented
Mar 23, 2020
* feat: add prefer-screen-queries Closes #95 * docs: review changes
* refactor: repurpose obsolete rule BREAKING CHANGE: rule `no-get-by-for-checking-element-not-present` removed in favour of `prefer-presence-queries` * docs(prefer-presence-queries): update doc accordingly * feat(prefer-presence-queries): report presence or absence queries * test(prefer-presence-queries): add more valid cases * docs(prefer-presence-queries): fix typos Co-Authored-By: Ben Monro <ben.monro@gmail.com> * test(prefer-presence-queries): include correct findBy example * test(prefer-presence-queries): findBy typo * feat(prefer-presence-queries): include array queries * fix(prefer-presence-queries): guard against nil matcher * docs(prefer-presence-queries): update appearance references Co-authored-by: Ben Monro <ben.monro@gmail.com>
Member
Author
|
v3 ready to review. I tested it in a large codebase with more +3k tests. Everything looks fine, the |
Member
|
🥳 Awesome to hear that ✋ |
timdeschryver
approved these changes
Mar 29, 2020
Member
timdeschryver
left a comment
There was a problem hiding this comment.
Gave it a quick look and everything seems to have been merged successfully.
LGTM 👍
Member
Author
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
Author
|
@all-contributors please add @timdeschryver for code, doc, ideas, review and test |
Contributor
|
I've put up a pull request to add @timdeschryver! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #93