Conversation
Member
|
|
BREAKING CHANGE: Requires Node@^12.22.x || ^14.17.x || >=16.x
BREAKING CHANGE: `no-debug` is now called `no-debugging-utils`
BREAKING CHANGE: `no-unnecessary-act` is now enabled by default in the React config (with `isStrict` set to `true`)
…ult (#481) BREAKING CHANGE: `no-render-in-setup` is now enabled by default in the Angular, React & Vue configs
…483) BREAKING CHANGE: `no-wait-for-multiple-assertions` is now enabled by default in all configs
BREAKING CHANGE: `no-wait-for-side-effects` is now enabled by default in all configs
BREAKING CHANGE: `no-wait-for-snapshot` is now enabled by default in all configs
BREAKING CHANGE: `prefer-presence-queries` is now enabled by default in all configs
* feat: support ESLint 8.x * feat: support ESLint 8.x * chore: downgrade ESLint to v7 in dev deps * ci: force deps installation for running tests Co-authored-by: Mario Beltrán Alarcón <belco90@gmail.com>
Member
|
Everything should be ok now. I'm gonna add a "migration guide to v5" doc, and should be ready to go! |
Member
|
I've tested the alpha-10 version of the plugin in a repo of mine and works great for both ESLint v7 and v8! |
Member
|
Migration guide added, this is ready to go now! What do you think @MichaelDeBoey? |
timdeschryver
previously approved these changes
Oct 18, 2021
Member
timdeschryver
left a comment
There was a problem hiding this comment.
LGTM 👍
Seems like it was a smooth upgrade, good to know 🙂
Belco90
approved these changes
Oct 25, 2021
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains all of the changes for v5.0.0.
This branch will be rebased-merged on top of master for the release.
Because we need to ensure we're handling all breaking changes from ESLint v8 - we cannot release this until ESLint v8 is officially released.
That being said - this branch is released to NPM! You can install it via the
alphatag.Changelog
^12.22.0 || ^14.17.0 || >=16.0.0.no-debugis now calledno-debugging-utilsno-render-in-setupis now enabled by default in the Angular, React & Vue configsno-unnecessary-act'sisStrictoption is nowtrueby defaultno-unnecessary-actis now enabled by default in the React configno-wait-for-multiple-assertionsis now enabled by default in all configsno-wait-for-side-effectsis now enabled by default in all configsno-wait-for-snapshotis now enabled by default in all configsprefer-presence-queriesis now enabled by default in all configsprefer-query-by-disappearanceis now enabled by default in all configsCloses #478