fix(no-node-access): prevent duplicate errors for chained property access#1260
Merged
fix(no-node-access): prevent duplicate errors for chained property access#1260
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1260 +/- ##
=======================================
Coverage 97.35% 97.35%
=======================================
Files 49 49
Lines 6009 6012 +3
Branches 1536 1538 +2
=======================================
+ Hits 5850 5853 +3
Misses 157 157
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Belco90
approved these changes
Mar 19, 2026
|
🎉 This PR is included in version 7.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
MemberExpressionContext
Fixes #1256
The
no-node-accessrule was reporting duplicate errors when DOM properties were chained (e.g.,element.parentElement.nextElementSibling). This was because the selector'VariableDeclarator MemberExpression'matched all nested MemberExpression nodes.The fix adds a check to skip MemberExpression nodes that serve as the object of parent MemberExpressions, preventing duplicate reports for chained property access.