fix: check namespaced import properly for no-debug and prefer-wait-for#102
Merged
fix: check namespaced import properly for no-debug and prefer-wait-for#102
no-debug and prefer-wait-for#102Conversation
no-debug and prefer-wait-for
Member
Author
|
Same issue fixed for |
timdeschryver
approved these changes
Mar 31, 2020
Member
timdeschryver
left a comment
There was a problem hiding this comment.
LGTM
On a side note, I don't like all these different ways to import while working on linters 😅
Member
Author
Yeah, me either. We have mentioned few times in different PRs that we should migrate the plugin to TS so we can use TSESLint experimental utils. It would probably help to use generic methods to check this kind of things. |
Member
Author
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101