Skip to content

refactor: Require rule name in createTestingLibraryRule return type and use rule.name in tests#1171

Merged
Belco90 merged 4 commits intomainfrom
refactor/create-testing-library-rule-return-type
Dec 31, 2025
Merged

refactor: Require rule name in createTestingLibraryRule return type and use rule.name in tests#1171
Belco90 merged 4 commits intomainfrom
refactor/create-testing-library-rule-return-type

Conversation

@y-hsgw
Copy link
Member

@y-hsgw y-hsgw commented Dec 30, 2025 •
edited
Loading

Checks

Changes

  • Make name required in the createTestingLibraryRule return type for stronger rule contracts.
  • Update rule tests to pass rule.name to ruleTester.run instead of RULE_NAME.

Context

typescript-eslint/typescript-eslint#11608

@codecov
Copy link

codecov bot commented Dec 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.35%. Comparing base (b8ac9fb) to head (da98b5c).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1171   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files          49       49           
  Lines        6009     6009           
  Branches     1536     1536           
=======================================
  Hits         5850     5850           
  Misses        157      157           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Belco90 Belco90 self-requested a review December 31, 2025 07:53
Belco90
Belco90 approved these changes Dec 31, 2025
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@Belco90 Belco90 merged commit b8ef377 into main Dec 31, 2025
21 checks passed
@Belco90 Belco90 deleted the refactor/create-testing-library-rule-return-type branch December 31, 2025 08:08
@github-actions
Copy link

github-actions bot commented Dec 31, 2025

🎉 This PR is included in version 7.15.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees

@y-hsgw y-hsgw

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@y-hsgw @Belco90