Skip to content

Fix incorrect imports in types#556

Merged
kentcdodds merged 5 commits intotesting-library:masterfrom
nstepien:patch-1
May 7, 2020
Merged

Fix incorrect imports in types#556
kentcdodds merged 5 commits intotesting-library:masterfrom
nstepien:patch-1

Conversation

@nstepien
Copy link
Copy Markdown
Contributor

@nstepien nstepien commented May 7, 2020 •
edited
Loading

What: Fixing invalid imports

> tsc -p tsconfig.all.json

node_modules/@testing-library/dom/types/queries.d.ts:3:32 - error TS2307: Cannot find module 'wait-for'.

3 import { waitForOptions } from 'wait-for';
                                 ~~~~~~~~~~

node_modules/@testing-library/dom/types/wait-for-dom-change.d.ts:1:32 - error TS2307: Cannot find module 'index'.

1 import { waitForOptions } from "index";
                                 ~~~~~~~

node_modules/@testing-library/dom/types/wait-for-element-to-be-removed.d.ts:1:32 - error 
TS2307: Cannot find module 'wait-for'.

1 import { waitForOptions } from "wait-for";
                                 ~~~~~~~~~~

node_modules/@testing-library/dom/types/wait-for-element.d.ts:1:32 - error TS2307: Cannot find module 'wait-for'.

1 import { waitForOptions } from "wait-for";
                                 ~~~~~~~~~~


Found 4 errors.

Why: It's breaking my builds

How: N/A

Checklist:

@nstepien nstepien mentioned this pull request May 7, 2020
Merged
2 tasks
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented May 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e0cb20:

Sandbox Source
serene-wescoff-6qgzw Configuration

nstepien
nstepien commented May 7, 2020
View reviewed changes
types/get-queries-for-element.d.ts
@@ -1,4 +1,3 @@
import { Matcher } from './matches';
Copy link
Copy Markdown
Contributor Author

@nstepien nstepien May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's unused.

kentcdodds
kentcdodds approved these changes May 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit af15dd9 into testing-library:master May 7, 2020
@kentcdodds
Copy link
Copy Markdown
Member

kentcdodds commented May 7, 2020

🎉 This PR is included in version 7.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kentcdodds
Copy link
Copy Markdown
Member

kentcdodds commented May 7, 2020

@all-contributors please add @nstepien for code

@allcontributors allcontributors bot mentioned this pull request May 7, 2020
Merged
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors bot commented May 7, 2020

@kentcdodds

I've put up a pull request to add @nstepien! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nstepien @kentcdodds