feat(waitFor): improve error message for non-function callbacks#515
Merged
feat(waitFor): improve error message for non-function callbacks#515
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 05aa661:
|
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 426 428 +2
Branches 101 102 +1
=========================================
+ Hits 426 428 +2
Continue to review full report at Codecov.
|
eps1lon
reviewed
Mar 31, 2020
eps1lon
previously approved these changes
Mar 31, 2020
Member
eps1lon
left a comment
There was a problem hiding this comment.
Looks good. Just some minor nitpicks.
afontcu
approved these changes
Mar 31, 2020
eps1lon
approved these changes
Mar 31, 2020
Member
|
@Belco90 Looking good, thanks! |
Member
|
🎉 This PR is included in version 7.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Closes #509
Why:
To improve error message and error stack trace
How:
Checking if
callbackis a function.Checklist:
docs site
DefinitelyTyped