fix: queryHelpers.getElementError is not a function#510
fix: queryHelpers.getElementError is not a function#510kentcdodds merged 3 commits intotesting-library:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7fe836d:
|
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 23 23
Lines 425 426 +1
Branches 101 101
=====================================
+ Hits 425 426 +1
Continue to review full report at Codecov.
|
kentcdodds
left a comment
There was a problem hiding this comment.
Looks good. Just one small change now that we have this function :)
|
@all-contributors please add @Yama-Tomo for code and tests |
|
I've put up a pull request to add @Yama-Tomo! 🎉 |
|
🎉 This PR is included in version 7.1.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
If you try to call getElementError in a custom query according to the documentation, you will get an error.
Why:
getElementError was removed in #452.
How:
redefine to queryHelpers
Checklist:
docs site
DefinitelyTyped
NOTE:
I asked a question about this issue. #508
This can be done by require of
@testing-library/dom/dist/config, but I'm wondering if that's the official way to do it (It was a question I wanted to ask on thatissue).Please close this PR if that is official way.
Thanks!