feat: Reduce caught exceptions in prettyDom (reland)#1323
Merged
Conversation
4 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 964d6e8:
|
eps1lon
commented
Jul 5, 2024
src/pretty-dom.js
Outdated
| // Try to safely parse env COLORS: We will default behavior if any step fails. | ||
| try { | ||
| const colors = process?.env?.COLORS | ||
| const colors = typeof process !== 'undefined' ? process?.env?.COLORS : undefined |
Member
Author
There was a problem hiding this comment.
One less caught exception
MatanBobi
previously approved these changes
Jul 5, 2024
process only if defined05c66d9 to
3db439b
Compare
DavidRieman
approved these changes
Jul 20, 2024
Contributor
DavidRieman
left a comment
There was a problem hiding this comment.
LGTM. Yes I believe you captured the intend of my PR well. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1324
Relands #1321 which originally caused #1322
@DavidRieman Could you give this a look if
3db439b(#1323) is still matching your original intention?