feat: Drop support for Node.js 12.x#1207
Merged
eps1lon merged 1 commit intotesting-library:alphafrom Jan 29, 2023
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b092065:
|
Codecov Report
@@ Coverage Diff @@
## main #1207 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 998 998
Branches 327 327
=========================================
Hits 998 998
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
timdeschryver
approved these changes
Jan 28, 2023
Member
timdeschryver
left a comment
There was a problem hiding this comment.
LGTM 👍
Do you think we should also add v19 to the test matrix?
Member
Author
Sure |
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Minimum supported Node.js version is now 14.x
What:
Drop support for Node.js 12.x
Why:
Reached EOL in April 2022. Tooling is starting to drop Node.js 12.x (see JSDOM) as well so it's time to upgrade to be able to test compat with latest test frameworks (e.g. Jest).
How:
Targetting alpha for now. Want to batch this with #1202
Look for occurence of "12" and update where appropriate. Also introducing Node.js 18.x into test matrix since that is now in Active LTS
Checklist:
docs site