Skip to content

feat: improve browser examples#1539

Merged
laurentsenta merged 8 commits intotestground:masterfrom
GlenDC:feat/1386-improve-docker-node-example
Dec 8, 2022
Merged

feat: improve browser examples#1539
laurentsenta merged 8 commits intotestground:masterfrom
GlenDC:feat/1386-improve-docker-node-example

Conversation

@GlenDC
Copy link
Copy Markdown
Contributor

@GlenDC GlenDC commented Dec 5, 2022 •
edited
Loading

Implement follow ups in my power as mentioned by @laurentsenta in #1502 (review).

Summary:

  • replace the BrowserKind test paramater with runtime, which by default is node, but
    • can also be set to chromium, firefox and webkit.
  • enable the sync test for the browser-node example
    • also added a sh script to run that same test for the regular js example (while I was at it)

For the sdk-js (third) point I created an issue at testground/sdk-js#28. I do not mind to also work on that one everything that still might need to be done before you can make a release. The release however will have to be done by the sdk-js maintainers (you?).

In function of #1386

@GlenDC GlenDC mentioned this pull request Dec 5, 2022
Closed
12 tasks
@laurentsenta
Copy link
Copy Markdown
Contributor

laurentsenta commented Dec 6, 2022

Thanks for the care you put into this PR, it looks great,
with the sync test, at the moment, we run 1 sync test with 2 node instances, 1 sync test with 2 firefox instances, etc.

Since the next step for this work is to test interoperability, we would cover more features by having 1 sync test that runs with 1 node instance, 1 firefox, and 1 chrome. together. Could you look into creating this composition? I can help with writing it.

@GlenDC
Copy link
Copy Markdown
Contributor Author

GlenDC commented Dec 7, 2022

Thanks for the care you put into this PR, it looks great, with the sync test, at the moment, we run 1 sync test with 2 node instances, 1 sync test with 2 firefox instances, etc.

Since the next step for this work is to test interoperability, we would cover more features by having 1 sync test that runs with 1 node instance, 1 firefox, and 1 chrome. together. Could you look into creating this composition? I can help with writing it.

@laurentsenta the integration test cross-runtime for sync has been added. This one tests using an instance of node, chromium, firefox and webkit. Can you please re-review?

laurentsenta
laurentsenta reviewed Dec 7, 2022
View reviewed changes
@laurentsenta laurentsenta force-pushed the feat/1386-improve-docker-node-example branch from b651a09 to 613a2ad Compare December 7, 2022 12:05
@laurentsenta laurentsenta requested review from galargh and nonsense and removed request for nonsense December 7, 2022 12:06
@laurentsenta laurentsenta changed the title Feat/1386 improve docker node example feat: improve browser examples Dec 7, 2022
@laurentsenta
Copy link
Copy Markdown
Contributor

laurentsenta commented Dec 7, 2022 •
edited
Loading

(rebased + bumped the sdk-js version @GlenDC thanks for the great work. I'll tag @galargh so he gets a change to review then merge tomorrow)

@laurentsenta laurentsenta merged commit 5c43c33 into testground:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurentsenta laurentsenta laurentsenta approved these changes

@galargh galargh Awaiting requested review from galargh

Assignees

@GlenDC GlenDC

Labels

None yet

Projects

Testground Project Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GlenDC @laurentsenta