Merged
Conversation
38641c8 to
bb301ad
Compare
9964496 to
7c74f8b
Compare
galargh
approved these changes
Nov 16, 2022
Contributor
galargh
left a comment
There was a problem hiding this comment.
Thanks for the explanation yesterday 🙇 Looks good, nothing blocking on my side 🚀
We're doing a `-eq 0` test, this is confusing: When a user does `SKIP_AUTO_START=true ./script`, `[[ true -eq 0 ]]` is true, and the daemon is started.
- flatten the structure, we'll come back to these to fix them - fix the fields that where NEVER decoded because of `_` - make the write composition file reusable outside of api package
- drop noisy comments - rename function for consistency - move code for symmetry
debb731 to
1c95ba1
Compare
This was referenced Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1493
Dear reviewers, extra care is taken to have clean commit steps. In case we want to split this PR.
It will be much nicer to review by going through the git history (in github: open the first commit then use the Prev / Next buttons).
pickandtomlandwithEnvcomposition.gointo 3 different files (prepare, validate, and data)mapstructsrunsfieldrunidsparametersKnown issues
the
runsfield is processed client-sideWe have two options when sending a composition with multiple
runseither:Follow-up Tasks
See #1493