feat: support environment variables for local docker#1507
feat: support environment variables for local docker#1507GlenDC wants to merge 10 commits intotestground:masterfrom
Conversation
|
@laurentsenta can this be reviewed so we can aim to merge? |
|
@GlenDC 👍 Could you add tests and a line in the changelog? |
Sure thing. Will do and I'll let you know once it is done! |
|
@laurentsenta the changelog line is added, and I've added this to an existing example plan. How do you actually pass run config values when running a plan via CLI? There is |
Could you also explain me that @laurentsenta, as I would want to do that for my browser plan I imagine, in between different tests on same image? |
and enable additional* tests in integration tests in the Makefile
dropped the bash-generic test as it would be too much effort to create also the out files etc :)
|
@laurentsenta all tests have been enabled and PR is ready for being merged what is me concerned. |
GlenDC
left a comment
There was a problem hiding this comment.
Self-Reviewed it again as well, looks all good to me!
it wasn't enabled previously either, so I consider this out of scope for my current task
|
@laurentsenta what more would you need to be done here before we can more towards a merge path? |
|
Going to close this one as for now there is not enough motivation to really add this feature, given that it's considered better practise to use parameters (SDK) for these purposes. |
additional_envsoption todocker:runnerwhich lets a user override envs.Closes #1505