Skip to content

Feat/1386 browser hello world test#1474

Merged
laurentsenta merged 6 commits intotestground:masterfrom
GlenDC:feat/1386-browser-hello-world-test
Oct 5, 2022
Merged

Feat/1386 browser hello world test#1474
laurentsenta merged 6 commits intotestground:masterfrom
GlenDC:feat/1386-browser-hello-world-test

Conversation

@GlenDC
Copy link
Copy Markdown
Contributor

@GlenDC GlenDC commented Sep 24, 2022 •
edited
Loading

Add browser hello testplan and integration tests, making use of playwright and docker:generic,
in function of issue #1386

Feature/Requirement checklist:

  • hello browser testplan
  • hello browser integration test
    • success integration test
    • failure integration test

Usage example of hello world testplan:

testground plan import --from ./plans/example-browser

testground run single \
    --plan example-browser --testcase success \
    --instances 1 \
    --builder docker:generic --runner local:docker \
    --tp browser=firefox --wait

You can run firefox/chromium for both success and failure cases using the single integration test:

./integration_tests/example_04_browser.sh

Secondary Requirement checklist:

Question: should we do that as part of this PR, or a new one?

Answer: a new PR

  • use testground sdk directly from browser
  • add test plan to showcase how to do this
  • add integration tests which makes use of this testplan

@GlenDC
Copy link
Copy Markdown
Contributor Author

GlenDC commented Sep 24, 2022

Placebo integration test seems to fail, which is unrelated from the work done for this PR?

@GlenDC GlenDC mentioned this pull request Sep 25, 2022
Closed
12 tasks
@mxinden mxinden mentioned this pull request Sep 26, 2022
Merged
19 tasks
brdji
brdji reviewed Sep 26, 2022
View reviewed changes
brdji
brdji reviewed Sep 26, 2022
View reviewed changes
brdji
brdji reviewed Sep 26, 2022
View reviewed changes
@laurentsenta
Copy link
Copy Markdown
Contributor

laurentsenta commented Sep 28, 2022

The CI issues should have been fixed, could you rebase on master @GlenDC ?

@GlenDC GlenDC force-pushed the feat/1386-browser-hello-world-test branch from e59d6cf to bd05cc5 Compare September 28, 2022 22:32
@GlenDC
Copy link
Copy Markdown
Contributor Author

GlenDC commented Sep 30, 2022

@laurentsenta can this branch be merged by you, or do we need to wait for more reviews?

@laurentsenta
Copy link
Copy Markdown
Contributor

laurentsenta commented Oct 3, 2022

@GlenDC thanks for the ping, could you rebase over the latest master? I'll make sure this goes in next.
@brdji could you approve the PR if you are satisfied with the latest changes?

@GlenDC GlenDC force-pushed the feat/1386-browser-hello-world-test branch from bd05cc5 to 864bf90 Compare October 3, 2022 22:36
@GlenDC
Copy link
Copy Markdown
Contributor Author

GlenDC commented Oct 3, 2022 •
edited
Loading

@GlenDC thanks for the ping, could you rebase over the latest master? I'll make sure this goes in next.
@brdji could you approve the PR if you are satisfied with the latest changes?

Ok, @laurentsenta. Master rebased. Ready for approval and merge.
Locally I already am working on step 2 and I'll open a Draft PR once this one is merged in.

brdji
brdji approved these changes Oct 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@brdji brdji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@GlenDC
Copy link
Copy Markdown
Contributor Author

GlenDC commented Oct 4, 2022

@laurentsenta ball is in your camp again, as I do not have merge rights. All good now AFAIK.

@mxinden
Copy link
Copy Markdown
Member

mxinden commented Oct 4, 2022

Thanks for all the work here.

//CC @achingbrain for visibility.

@laurentsenta laurentsenta merged commit 4caa841 into testground:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurentsenta laurentsenta laurentsenta approved these changes

@nonsense nonsense Awaiting requested review from nonsense

@galargh galargh Awaiting requested review from galargh

+1 more reviewer

@brdji brdji brdji approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GlenDC @laurentsenta @mxinden @brdji