Skip to content

feat: various usability & stabiliy improvements for interop#1421

Merged
laurentsenta merged 8 commits intomasterfrom
feat/without-timeout
Aug 19, 2022
Merged

feat: various usability & stabiliy improvements for interop#1421
laurentsenta merged 8 commits intomasterfrom
feat/without-timeout

Conversation

@laurentsenta
Copy link
Copy Markdown
Contributor

@laurentsenta laurentsenta commented Aug 5, 2022 •
edited
Loading

  • Introduce split operation in composition templates
  • Add a load_resource operation in composition templates
    • This lets a user define configuration in a file (like a list of instances) and use them during composition templating.
  • drop arbitrary build timeout (we have a task timeout)
  • drop instance count requirements when we can deduce it
  • provide composition templating during build (it was only applied during run before)
  • Add a concurrency option to build artifacts one by one
    • When working on rust interop tests, I noticed we lose the benefits of docker caching & explodes storage requirements because we start every build at the same time.

@laurentsenta laurentsenta marked this pull request as draft August 5, 2022 17:22
@laurentsenta laurentsenta force-pushed the feat/without-timeout branch from 56073df to 8afb8d4 Compare August 5, 2022 17:25
@laurentsenta laurentsenta mentioned this pull request Aug 10, 2022
Merged
6 tasks
@laurentsenta laurentsenta force-pushed the feat/without-timeout branch 2 times, most recently from 25ec83f to 69c364d Compare August 11, 2022 12:28
@laurentsenta laurentsenta changed the title feat: features & improvements feat: various usability & stabiliy improvements for interop Aug 11, 2022
@laurentsenta laurentsenta marked this pull request as ready for review August 11, 2022 16:03
@laurentsenta
Copy link
Copy Markdown
Contributor Author

laurentsenta commented Aug 11, 2022

Marking for review,
Note each commit is one feature, I think having a single PR will save us time, but I can extract 1 PR per commit if needed.

brdji
brdji reviewed Aug 15, 2022
View reviewed changes
brdji
brdji reviewed Aug 15, 2022
View reviewed changes
@laurentsenta laurentsenta mentioned this pull request Aug 18, 2022
Closed
@laurentsenta laurentsenta requested a review from brdji August 18, 2022 12:53
@laurentsenta
Copy link
Copy Markdown
Contributor Author

laurentsenta commented Aug 19, 2022

Merging, thanks for the review @brdji

@laurentsenta laurentsenta merged commit eaab278 into master Aug 19, 2022
@laurentsenta laurentsenta deleted the feat/without-timeout branch August 19, 2022 08:59
@laurentsenta laurentsenta mentioned this pull request Dec 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galargh galargh Awaiting requested review from galargh

@nonsense nonsense Awaiting requested review from nonsense

1 more reviewer

@brdji brdji brdji approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@laurentsenta @brdji