Skip to content

feat: print explicit outcome#1345

Merged
laurentsenta merged 4 commits intomasterfrom
feat/clarify-job-outcome
Jun 6, 2022
Merged

feat: print explicit outcome#1345
laurentsenta merged 4 commits intomasterfrom
feat/clarify-job-outcome

Conversation

@laurentsenta
Copy link
Copy Markdown
Contributor

@laurentsenta laurentsenta commented Jun 3, 2022

Fix #1344.

The daemon logs "run successfully" when a test execution completes without an error. Even if the test itself failed.
This PR changes the message and logs the actual test outcome in the daemon stdout.
This is less confusing for users and maintainers.

Example

testground run single --plan=example --testcase=output --builder=docker:go --runner=local:docker --instances=1 --wait

Would print "run finished successfully",
but now will print:

Jun  3 06:27:47.137053  INFO    run finished with outcome = failure (single:0/1)        {"run_id": "cacqjoa87d5grq4abs70", "plan": "example", "case": "output", "runner": "local:docker", "instances": 1}

Todo

  • change the logging message
  • update the dashboard message
  • make sure it is not breaking other parts of the code

@laurentsenta laurentsenta marked this pull request as draft June 3, 2022 06:29
@laurentsenta laurentsenta force-pushed the feat/clarify-job-outcome branch from d054068 to b013bb6 Compare June 3, 2022 06:59
@laurentsenta laurentsenta requested a review from galargh June 3, 2022 07:03
@laurentsenta laurentsenta marked this pull request as ready for review June 3, 2022 07:03
@laurentsenta laurentsenta requested review from brdji and nonsense June 3, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Job outcome is not clear when you read the daemon's stdout.

2 participants