Skip to content

bug: build key doesn't take the target into account #1366

@laurentsenta

Description

@laurentsenta

Version information:

ced4bb1 (current master)

Description:

If you define a group in a composition file, with a dependency override, for example:

[metadata]
  name = "go-cross-versions {{ .Env.Reference }}"

[global]
  plan = "libp2p/ping/go"
  case = "ping"
  total_instances = 2
  builder = "docker:go"
  runner = "local:docker"

[[groups]]
  id = "a"
  instances = { count = 1 }

  [groups.build]
    [[groups.build.dependencies]]
      module = "github.com/libp2p/go-libp2p"
      target = "libp2p/go-libp2p"
      version = "master"

[[groups]]
  id = "b"
  instances = { count = 1 }

  [groups.build]
    [[groups.build.dependencies]]
      module = "github.com/libp2p/go-libp2p"
      target = "laurent/go-libp2p" # note the different target
      version = "master"

The current build key won't take into account the target, which means that testground builds a single container and use this. One of the two overwrite will be "forgotten".

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1P1: Must be fixed.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions