Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@nonsense I think this PR is ready for review. I did not write unit tests as this library is very well exercises by the integration tests we have on Testgroud side. In addition, all unit tests we had for Redis were moved to the main repo, for the sync service. |
This was referenced Feb 23, 2021
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
nonsense
approved these changes
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the sync package implementation to use the new sync service. Read more at testground/sync-service#4.