Fix ClickHouse wait strategy#9466
Merged
eddumelendez merged 2 commits intotestcontainers:mainfrom Oct 31, 2024
Merged
Conversation
Member
|
good catch, @livk-cloud! However, I am running tests locally and some are failing. Can you please take a look? |
Contributor
Author
|
@eddumelendez You should tell me that there is a problem with those tests so that we can better fix them |
Member
|
All should be good now. Thanks anyway. |
Contributor
Author
|
That's great, thank you for reviewing and testing , I hope that the next version can be updated, so that it will be more convenient and easy to use when using ClickHouse R2dbc |
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the addition of this PR
#8434
#9465