Remove superficial Kafka optimization for the sake of clarity#7030
Closed
danielpetisme wants to merge 1 commit intotestcontainers:mainfrom
Closed
Remove superficial Kafka optimization for the sake of clarity#7030danielpetisme wants to merge 1 commit intotestcontainers:mainfrom
danielpetisme wants to merge 1 commit intotestcontainers:mainfrom
Conversation
Member
|
look like the example test and examples for kafka fail 👀 |
Contributor
Author
|
Have been looking at the failures... Beyond just variable verification, the These 6 lines should be removed only when Kraft enabled && CP < 7.4 |
Contributor
Author
|
@eddumelendez Actually I think this PR is a bad idea. |
Member
|
feel free to close it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kafka module is skipping the
/etc/confluent/docker/ensurechecks for the optimization reasons.The checks performed in this script are super lightweight and don't worth the code complexity it brings.
Discussions
#7014 (comment)