Skip to content

Fix for VNC recorder not stopping #6307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
deejgregor wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix for VNC recorder not stopping #6307

deejgregor wants to merge 2 commits into from
+148 −16

Conversation

@deejgregor
Copy link
Contributor

@deejgregor deejgregor commented Dec 15, 2022

Fixes issue #5268 where the VNC recorder is not stopped when a test is over.

See discussion #6229 for more information.

Also improve error reporting when the VNC recording command fails.

@deejgregor
Stop VNC recorder when test ends (testcontainers#5268)
2f9f45b 
For details, see discussion testcontainers#6229.
@deejgregor
Improve error reporting when VNC recording command fails
5fc5cce 
Also deduplicate common code in the reencodeRecording implementations.
@deejgregor deejgregor force-pushed the fix-vnc-recorder-does-not-stop branch from 50ebdfd to 5fc5cce Compare December 15, 2022 05:20
@deejgregor deejgregor marked this pull request as ready for review December 15, 2022 06:34
@deejgregor deejgregor requested a review from a team December 15, 2022 06:34
@deejgregor deejgregor mentioned this pull request Dec 15, 2022
Open
@eddumelendez eddumelendez requested a review from a team as a code owner August 19, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

modules/selenium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@deejgregor