QuestDB Container module#5606
Closed
jerrinot wants to merge 5 commits into
Closed
Conversation
jerrinot
commented
Jul 22, 2022
eddumelendez
left a comment
Member
There was a problem hiding this comment.
Thanks @jerrinot ! Can we add docs, please?
Contributor
Author
|
hi @eddumelendez, thanks for a quick reply! |
Member
|
@jerrinot can you please add questdb to
|
kiview
requested changes
Aug 8, 2022
| @@ -0,0 +1,77 @@ | |||
| package org.testcontainers.containers; | |||
Member
There was a problem hiding this comment.
Suggested change
| package org.testcontainers.containers; | |
| package org.testcontainers.questdb; |
Going ahead, new modules should use a package name following org.testcontainers.{module-name}, to avoid Split Package issues with JMS.
Member
|
@jerrinot just pinging to see if you are willing to work on the suggestions/requested changes 🙂 |
Contributor
Author
|
@eddumelendez hi, yes, totally. sorry for going silent. need to find some time. it's still on my radar. |
Contributor
Author
|
closing in favour of #5995 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, QuestDB has 8900+ GitHub stars, and I believe users will benefit from this.
I realise this is incomplete and documentation is lacking. I'm sending this as a draft to get some early feedback on whether you would consider merging this at all. If so, I would be keen to contribute this to TestContainers for other platforms, starting with Python.
Any feedback is much appreciated!