Use non debug images if selenium version is 4.x #4686
Closed
tobiasstadler wants to merge 1 commit intotestcontainers:masterfrom
Closed
Use non debug images if selenium version is 4.x #4686tobiasstadler wants to merge 1 commit intotestcontainers:masterfrom
tobiasstadler wants to merge 1 commit intotestcontainers:masterfrom
Conversation
…d in the "normal" image".
Contributor
Author
|
@kiview Would you please have a look? |
Member
|
Hey @tobiasstadler, sorry for not yet taking care of this issue and the PR, we know it is important for the community. Thanks for helping out so far! Currently, we are thinking about solving this in the direction of the PR and I hope we will find the time to finalize it: In this PR we try to take this opportunity to clean up the module further. We might be able to include these changes there (we of course give credit). |
Contributor
Author
|
Great, I am looking forward to it. |
Member
|
Superseded by #4914. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should prevent errors like #4674.