Merged
Conversation
Fixes #4485
bsideup
reviewed
Oct 14, 2021
bsideup
reviewed
Oct 14, 2021
rnorth
commented
Oct 18, 2021
modules/k3s/src/test/java/org/testcontainers/k3s/Fabric8K3sContainerTest.java
Outdated
Show resolved
Hide resolved
rnorth
commented
Oct 18, 2021
modules/k3s/src/test/java/org/testcontainers/k3s/Fabric8K3sContainerTest.java
Outdated
Show resolved
Hide resolved
jorsol
reviewed
Dec 22, 2021
bsideup
reviewed
Dec 27, 2021
modules/k3s/src/main/java/org/testcontainers/k3s/K3sContainer.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Dec 27, 2021
modules/k3s/src/test/java/org/testcontainers/k3s/Fabric8K3sContainerTest.java
Show resolved
Hide resolved
bsideup
reviewed
Dec 29, 2021
bsideup
reviewed
Dec 29, 2021
modules/k3s/src/main/java/org/testcontainers/k3s/K3sContainer.java
Outdated
Show resolved
Hide resolved
bsideup
approved these changes
Dec 29, 2021
kiview
approved these changes
Jan 13, 2022
Member
kiview
left a comment
There was a problem hiding this comment.
LGTM, just missing the update of the dependabot.yml to include the module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4485
Keeping config options simple for now, and assuming that the k8s API is sufficient for any setup that people need to do.
TODO:
Possibly more extensive usage examples?I reckon what's there is probably good enough to get started.io.kubernetesclientECclient key workaround in test - is this a bug that we need to report to the fabric8 team?