resolves build args in FROM statements when using withDockerfile #3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Donnerbart
reviewed
Nov 3, 2022
| Optional<String> imageBuildArg = buildArgs.keySet() | ||
| .stream() | ||
| .filter(arg -> imageName.contains(arg)) | ||
| .findFirst(); |
Contributor
There was a problem hiding this comment.
This will only resolve a single match per FROM statement, right?
It also doesn't resolve the simple $VARIABLE pattern.
Author
There was a problem hiding this comment.
Yep good spot, it would need to check more than one - could well have multiple args for a image depending on how fine grained your need is
Author
There was a problem hiding this comment.
Also just seen your PR - I had been busy working on other projects and had forgot about this! I saw the notifications a few days ago so was going to see what was needed.
But happy for this to be closed in favour of your PR :)
Member
|
Closing in favor of #6119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3238