Skip to content

Disable Gradle daemon#1004

Merged
rnorth merged 4 commits into
masterfrom
travis-dind-no-share
Dec 4, 2018
Merged

Disable Gradle daemon#1004
rnorth merged 4 commits into
masterfrom
travis-dind-no-share

Conversation

@rnorth

@rnorth rnorth commented Dec 3, 2018

Copy link
Copy Markdown
Member

All branches on Travis CI have been failing in the Docker-in-Docker part of the build, with error logs similar to those shown in gradle/gradle#3318. It's hard to tell what's happening, but I'd like to try disabling the Gradle daemon: I suspect that the problem is due to the Gradle caches being accessed concurrently by the daemon from the install phase and the docker-in-docker phase.

As it's hard to really tell exactly what's going on, I'd like to try merging this and see if it stabilises things - I think it's pretty harmless and so far seems to work better.

Speculative change to resolve gradle/gradle#3318
@rnorth rnorth requested review from bsideup and kiview as code owners December 3, 2018 20:15
@rnorth rnorth changed the title WIP: Disable Gradle daemon Disable Gradle daemon Dec 3, 2018

@bsideup bsideup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also set a global env var with Gradle property

@rnorth

rnorth commented Dec 4, 2018

Copy link
Copy Markdown
Member Author

Cheers @bsideup, I think I'll keep as is for now, as it's fairly explicit.

@rnorth rnorth merged commit a8e1708 into master Dec 4, 2018
@delete-merged-branch delete-merged-branch Bot deleted the travis-dind-no-share branch December 4, 2018 10:15
@kiview

kiview commented Dec 4, 2018

Copy link
Copy Markdown
Member

It's probably better to do it in env var later, since we might forget to disable it when adding new jobs (it's a tiny thing of course).

So like GRADLE_OPTS=-Dorg.gradle.daemon=false?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants