feat(scylladb): add scylladb provider by danielhe4rt · Pull Request #2919 · testcontainers/testcontainers-go

danielhe4rt · 2024-12-13T16:29:45Z

What does this PR do?

Implements the Database ScyllaDB as a new provider.

Under the ScyllaDBContainer you will have the possibility of:

Enable Shard Awareness port using WithShardAwareness;
Set Docker Start Commands with WithCommand
Fetch ports with ConnectionHost
Enable ScyllaDB Alternator Endpoint (DynamoDB Compatible API)

API Example

ctx := context.Background()

ctr, err := scylladb.Run(ctx,
   "scylladb/scylla:6.2",
   scylladb.WithConfigFile(filepath.Join("testdata", "scylla.yaml")),
   scylladb.WithShardAwareness(),
   //...
)

Why is it important?

ScyllaDB is a NoSQL Database that is being constantly used by big companies and acts as a Drop-in Replacement to CassandraDB and DynamoDB.

How to test this PR

Clone the repository and enter the scylladb module folder:

git clone https://github.com/basementdevs/testcontainers-go basement-testcontainers-go
cd basement-testcontainers-go/modules/scylladb
make test

netlify · 2024-12-13T16:30:06Z

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	`aabf4d9`
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/6781712653ac6600080fbe71
😎 Deploy Preview	https://deploy-preview-2919--testcontainers-go.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…wareness

…rd-awareness port

stevenh

Thanks for a PR @danielhe4rt, have done an initial review with some suggestions and questions for you.

modules/scylladb/scylladb.go

modules/scylladb/scylladb_test.go

modules/scylladb/testdata/scylla.yaml

eddumelendez · 2024-12-16T22:06:46Z

modules/scylladb/scylladb_test.go

@@ -0,0 +1,194 @@
+package scylladb_test


Can we include a test using ssl? I think would be nice to have.

modules/scylladb/scylladb_test.go

eddumelendez · 2024-12-17T22:10:21Z

modules/scylladb/scylladb.go

+}
+
+// WithShardAwareness enable shard-awareness in the ScyllaDB container so you can use the `19042` port.
+func WithShardAwareness() testcontainers.CustomizeRequestOption {


scylladb starts both ports 9042 and 19042 by default. IMO we should expose a fn to get the mapped port for 19042 and omit this one.

@danielhe4rt @eddumelendez I'm taking over the PR and adding the suggestions on top of the original PR.

I'd like to have this in the upcoming release.

Thanks all for your time here

Ups, I noticed this PR is sent from the main branch of the fork, so unfortunately I cannot contribute commits to it.

@danielhe4rt could you please address the above comments 🙏 ?

Done! Sorry for the delay. Tomorrow I'll sync with @CodeLieutenant and finish it for good. Give us one more day @mdelapenya. We're also gonna stream it, so you can find us on twitch.tv/danielhe4rt.

Co-authored-by: Steven Hartland <stevenmhartland@gmail.com>

mdelapenya

@danielhe4rt thanks for your time in this PR, I added a few comments/suggestions in the review.

Could you address them 🙏 ?

Thank you in advance

docs/modules/scylladb.md

modules/scylladb/examples_test.go

modules/scylladb/scylladb.go

modules/scylladb/scylladb_test.go

mdelapenya · 2025-01-10T10:47:49Z

modules/scylladb/scylladb_test.go

+	}, nil
+}
+
+func getDynamoAlternatorClient(t *testing.T, c *scylladb.Container, port int) (*dynamodb.Client, error) {


suggestion: if the assertions in the calling tests are all the same (create a table using the client), you may want to merge them into this helper function, and name it assertCreateTable(t *testing.T). You could also merge the createTable helper

mdelapenya · 2025-02-26T06:56:41Z

Thanks @danielhe4rt for your initial work in this PR 🙇 We merged it in the follow-up PR and will be released in the upcoming new release 🚀 Spread the word!

danielhe4rt requested a review from a team as a code owner December 13, 2024 16:29

danielhe4rt and others added 17 commits December 13, 2024 13:33

feat(scylladb): add base packages

672e6a7

feat(scylladb): container implementation with file config and shard-a…

41ed131

…wareness

feat(scylladb): container base test implementation with files and sha…

0003747

…rd-awareness port

feat(scylladb): add makefile test runner command

6a472cb

feat(scylladb): add alternator integration

264d462

feat(scylladb): add WithCustomCommand and code cleanup

680c279

feat(scylladb): implementation cleanup with test coverage

a995a1c

docs(scylladb): add scylladb base documentation module

8f33187

docs: add links to the version it was introduced

7559c61

chore: add scaffolding files

75de222

chore: rename to Container

37ca8fc

chore: run mod tidy

7f7a476

fix: wrong state after code generation

e780e4f

chore: concat strings

95ca13f

chore: use int

01a4fef

chore: calculate variable once

4388885

chore: simplify types

c0f97ce

danielhe4rt force-pushed the main branch from 9d50ec1 to c0f97ce Compare December 13, 2024 16:33

stevenh requested changes Dec 15, 2024

View reviewed changes

eddumelendez reviewed Dec 16, 2024

View reviewed changes

eddumelendez reviewed Dec 17, 2024

View reviewed changes

modules/scylladb/scylladb_test.go Show resolved Hide resolved

eddumelendez reviewed Dec 17, 2024

View reviewed changes

eddumelendez mentioned this pull request Dec 17, 2024

Add scylladb module testcontainers/testcontainers-java#8002

Merged

danielhe4rt and others added 2 commits December 18, 2024 13:23

chore(scylladb): WithConfig standardising

82e5352

Co-authored-by: Steven Hartland <stevenmhartland@gmail.com>

Merge branch 'testcontainers:main' into main

cf070be

danielhe4rt requested a review from mdelapenya January 9, 2025 19:03

mdelapenya reviewed Jan 10, 2025

View reviewed changes

Merge branch 'testcontainers:main' into main

90caba2

chore(scylladb): WithConfig enhancements

aabf4d9

mdelapenya mentioned this pull request Feb 20, 2025

feat: add ScyllaDB module #2992

Merged

mdelapenya closed this in #2992 Feb 25, 2025

Uh oh!

Conversation

danielhe4rt commented Dec 13, 2024

What does this PR do?

API Example

Why is it important?

How to test this PR

Uh oh!

netlify bot commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for testcontainers-go ready!

Uh oh!

stevenh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eddumelendez Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eddumelendez Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

mdelapenya Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

mdelapenya Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

danielhe4rt Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

mdelapenya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdelapenya Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

mdelapenya commented Feb 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify bot commented Dec 13, 2024 •

edited

Loading