Skip to content

fix: upgrade docker client#1361

Closed
Slijkhuis wants to merge 1 commit intotestcontainers:mainfrom
Slijkhuis:upgrade-docker-client
Closed

fix: upgrade docker client#1361
Slijkhuis wants to merge 1 commit intotestcontainers:mainfrom
Slijkhuis:upgrade-docker-client

Conversation

@Slijkhuis
Copy link
Copy Markdown

@Slijkhuis Slijkhuis commented Jul 17, 2023 •
edited
Loading

What does this PR do?

Upgrades the github.com/docker/docker package.

The AuthConfig type was moved: moby/moby#43885. 👈 not relevant since I'm not upgrading to v24 anymore, but rather use the backported fix on v23.

Possibly https://github.com/testcontainers/moby-ryuk must be upgraded as well.

Why is it important?

You cannot use testcontainers-go with Go 1.20.6 currently, this PR should fix that.

Related issues

@Slijkhuis Slijkhuis requested a review from a team as a code owner July 17, 2023 07:32
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 17, 2023 •
edited
Loading

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 7ac9a90
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64b6d8bc4bf7d30008d8b4e9
😎 Deploy Preview https://deploy-preview-1361--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bryan-aguilar
Copy link
Copy Markdown

bryan-aguilar commented Jul 17, 2023

Another option would be to use the latest patch version of v23.0.x as the fix was backported.

AlexanderYastrebov
AlexanderYastrebov reviewed Jul 17, 2023
View reviewed changes
@Slijkhuis Slijkhuis force-pushed the upgrade-docker-client branch from cd73bb1 to 7ac9a90 Compare July 18, 2023 18:23
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Slijkhuis
Copy link
Copy Markdown
Author

Slijkhuis commented Jul 18, 2023

To reduce the scope of the PR I've reverted the changes that were required for upgrading the client to v24. I sticked with v23, but now use the backported fix, as @bryan-aguilar advised.

@djaglowski djaglowski mentioned this pull request Jul 19, 2023
Closed
@Slijkhuis
Copy link
Copy Markdown
Author

Slijkhuis commented Jul 20, 2023

FYI: as mentioned in the issue there is a discussion on whether to revert the changes that caused this to be a problem in the first place: golang/go#61431.

@oleg-nenashev oleg-nenashev mentioned this pull request Jul 20, 2023
Closed
@davideme
Copy link
Copy Markdown

davideme commented Jul 21, 2023

Any ETA on when have a release including this fix? It's blocking our CI pipeline for now.

@Slijkhuis
Copy link
Copy Markdown
Author

Slijkhuis commented Jul 21, 2023

Any ETA on when have a release including this fix? It's blocking our CI pipeline for now.

I can't merge it, it needs an approving review from @testcontainers/go-team. Which I also cannot tag.

@lanwen
Copy link
Copy Markdown

lanwen commented Jul 21, 2023

Hey @davideme you could try a workaround meanwhile

go get -u github.com/docker/docker@v23.0.7-0.20230718082441-f860ed7c77fc+incompatible

that worked for me

@AlexanderYastrebov
Copy link
Copy Markdown
Contributor

AlexanderYastrebov commented Jul 21, 2023

@Slijkhuis I am not from the testcontainers/go-team but rather in the users' boat :)

@mdelapenya
Copy link
Copy Markdown
Member

mdelapenya commented Jul 22, 2023

Hey folks, please take a look at #653.

I'll be back on Aug 1st and will prioritize this issue, which I've been actively following between diapers and baby bottles

@Slijkhuis
Copy link
Copy Markdown
Author

Slijkhuis commented Jul 24, 2023

Hey folks, please take a look at #653.

I'll be back on Aug 1st and will prioritize this issue, which I've been actively following between diapers and baby bottles

Sorry, I completely missed that issue. I'll be in the world of diapers and baby bottles myself somewhere early August :). So if you're back and I'm not responding just take control of this PR yourself!

@djaglowski djaglowski mentioned this pull request Jul 25, 2023
Closed
@lahabana lahabana mentioned this pull request Jul 26, 2023
Closed
6 tasks
@martin-helmich martin-helmich mentioned this pull request Jul 27, 2023
Open
@smhmayboudi
Copy link
Copy Markdown

smhmayboudi commented Jul 29, 2023

it would be very nice to check this pull request.

@srebhan srebhan mentioned this pull request Aug 1, 2023
Closed
This was referenced Aug 1, 2023
Merged
Closed
@mdelapenya
Copy link
Copy Markdown
Member

mdelapenya commented Aug 2, 2023 •
edited
Loading

I think we have a potential fix here: #1394. It supersedes this PR, as it includes bumps of the Docker dependency across all the modules, including updating deprecated APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderYastrebov AlexanderYastrebov Awaiting requested review from AlexanderYastrebov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: go 1.20.6: "http: invalid Host header, host port waiting failed"

7 participants

@Slijkhuis @bryan-aguilar @davideme @lanwen @AlexanderYastrebov @mdelapenya @smhmayboudi