Skip to content

chore: Remove EventStoreDb test project from SLNX file#1603

Merged
HofmeisterAn merged 1 commit intotestcontainers:developfrom
0xced:feature/remove-EventStoreDb-tests-slnx
Dec 13, 2025
Merged

chore: Remove EventStoreDb test project from SLNX file#1603
HofmeisterAn merged 1 commit intotestcontainers:developfrom
0xced:feature/remove-EventStoreDb-tests-slnx

Conversation

@0xced
Copy link
Contributor

@0xced 0xced commented Dec 12, 2025 •
edited by coderabbitai bot
Loading

What does this PR do?

This pull request removes Testcontainers.EventStoreDb.Tests.csproj from the slnx file. The EventStoreDb module was removed in ed192fb (sln) and 92af06f (slnx) but the tests must also be removed from the slnx file.

Why is it important?

It generates errors when using the slnx.

Related issues

#1599

Summary by CodeRabbit

  • Chores
    • Removed EventStoreDb test project from the solution configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@0xced
chore: Remove EventStoreDb tests from slnx
7ff23f5 
It was removed in ed192fb (sln) and 92af06f (slnx) but the tests must also be removed from the slnx file.
@netlify
Copy link

netlify bot commented Dec 12, 2025 •
edited
Loading

✅ Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 7ff23f5
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/693c8126754bab000859ee39
😎 Deploy Preview https://deploy-preview-1603--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Dec 12, 2025 •
edited
Loading

Walkthrough

The pull request removes the EventStoreDb test project reference from the Testcontainers.slnx solution file. This eliminates the tests/Testcontainers.EventStoreDb.Tests/Testcontainers.EventStoreDb.Tests.csproj entry from the tests folder solution configuration, streamlining the solution structure without functional code changes.

Changes

Cohort / File(s) Summary
EventStoreDb Test Project Removal
Testcontainers.slnx		 Removed the EventStoreDb test project reference from the solution file's tests section

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that the EventStoreDb test project removal is intentional and aligned with broader deprecation or removal efforts
  • Confirm no dependencies in other solution files or projects remain

Possibly related PRs

Suggested labels

chore

Poem

🐰 A hop, a skip, and one test away—
EventStoreDb has left the fray!
The solution file grows lean and light,
As cleanup rabbits set things right!
bzzzzt—gone! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description covers all mandatory sections with clear explanations of what, why, and includes related issue references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately summarizes the main change: removing the EventStoreDb test project from the SLNX file, which is the primary and only modification in this changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HofmeisterAn HofmeisterAn changed the title chore: Remove EventStoreDb tests from slnx chore: Remove EventStoreDb test project from SLNX file Dec 13, 2025
@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Dec 13, 2025
HofmeisterAn
HofmeisterAn approved these changes Dec 13, 2025
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci

@HofmeisterAn HofmeisterAn merged commit 17f5c4d into testcontainers:develop Dec 13, 2025
10 checks passed
@0xced 0xced deleted the feature/remove-EventStoreDb-tests-slnx branch December 13, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HofmeisterAn HofmeisterAn HofmeisterAn approved these changes

Assignees

No one assigned

Labels

chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xced @HofmeisterAn